Re: bug report - BUG: builtin/pack-objects.c:4310: should_include_obj should only be called on existing objects

From: Elijah Newren <newren@gmail.com>
Date: Apr 25, 2025, 18:30 UTC
Message-ID: <CABPp-BFiLURYmELQ1omyPJ+49cVxk1h4rPYj42zMwGUW-NUUGQ@mail.gmail.com>
In-Reply-To: <CA+ODqj2s68nPWzd1KHH3vUm3SiFHuf2b=+hmNuWesi-bo3c8_g@mail.gmail.com>

On Fri, Apr 25, 2025 at 11:15 AM Nik Garza <nikolas@applied.co> wrote:

>
> reporting the attached bug:

We prefer the bug be included inline rather than attached. However, from the reported error:

ERROR: Failed to fetch git tags from origin!
    Stdout:
    Stderr:
BUG: builtin/pack-objects.c:4310: should_include_obj should only be
called on existing objects
error: pack-objects died of signal 6
fatal: could not finish pack-objects to repack local links
fatal: index-pack failed

A couple quick checks shows:

$ git grep "should_include_obj should only be called on existing objects" builtin/pack-objects.c: BUG("should_include_obj should only be called on existing objects"); $ git log --pretty=reference -S"should_include_obj should only be called on existing objects" builtin/pack-objects.c c08589efdc5 (index-pack: repack local links into promisor packs, 2024-11-01)

which was a commit that was released as part of v2.48.0, and as you said, this started happening after you upgraded from 2.47 -> 2.49. Cc'ing the author of that commit for his comments.