git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Anyone know what is creating commits with bogus dates?

From
Elijah Newren <newren@gmail.com>
Date
May 21, 2020, 17:49 UTC
Message-ID
<CABPp-BFfa6q96qMUN07Dq3di6d3WuUzhyktBytbX=FGgarXgjg@mail.gmail.com>
Hi,

I wanted to report that we seem to have a number of repos in the wild with bogus (as in "won't even parse") dates.

I first discovered such a repository in the wild a while ago with rails.git. It has a commit with a recorded timezone of "+051800" for both author and committer. Everything else about the commit looks fine. See https://github.com/rails/rails/commit/4cf94979c9f4d6683c9338d694d5eb3106a4e734.

Some google searches at the time turned up a few other examples, all with the same "+051800" issue. I put a special workaround for it into filter-repo because I figured it was slightly prominent but probably limited to that special timezone. The fact that it was six digits but the last two were zeros made it seem not quite as bad as it could be.

Recently, I've gotten a few reports of commits existing in live repos with other forms of breakage. Dates that correspond to roughly a hundred years in the future, and with timezone specifiers that are either 7 or 8 digits long and no leading or trailing zeros. See https://github.com/newren/git-filter-repo/issues/88.

Is there rogue software somewhere creating some bad commit objects? Does anyone have any idea what might be causing these? Any suggestions on the right course(s) of action?

Right now, I'm leaning towards saying fast-import is right to bail on these, and maybe I'll investigate having filter-repo waste some cycles to try to detect these and report more helpful errors (though I really want to avoid full sanity checking as that's expensive). If I go that route, I'll probably make it link to the example command I provided in that bug report showing users how they can use filter-repo to fix those problems. Does that sound sane? Anything I'm missing?

Thanks, Elijah

Next: Eric Sunshine
Message 1 of 5 in “Anyone know what is creating commits with bogus dates?”
  1. Elijah NewrenMay 21, 2020
  2. Eric SunshineMay 21, 2020
  3. Jeff KingMay 21, 2020
  4. Elijah NewrenMay 21, 2020
  5. Jeff KingMay 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.