git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [bug?] clean: Demonstrate failure when used with paths

From
Elijah Newren <newren@gmail.com>
Date
Jun 3, 2019, 20:32 UTC
Message-ID
<CABPp-BFfYFj232cHd6_NTkEg1n8AOQ4Abm7ZrnLPWHJEDzUPsg@mail.gmail.com>
In-Reply-To
<CACUQV59ZQ=WLXa4iDw3nSJWnZpiqAYLOuoHKsNWj48uC=+k5KQ@mail.gmail.com>
On Mon, Jun 3, 2019 at 12:58 PM Rafael Ascensão <rafa.almas@gmail.com> wrote:
Show 6 quoted lines
>
> I missed this RFC series which fixes this and others issues:
> https://public-inbox.org/git/20180405173446.32372-1-newren@gmail.com
>
> Cheers,
> Rafael Ascensão

Yeah, I've had cleaning that patch series up on my TODO list for quite some time.

My vague recollection was that Peff pointed out a few things to clean up in my patches, and also highlighted a few extra adjacent issues in the surrounding underlying code...and when I started looking into fixing the additional stuff it was slightly more complex and ugly (and for some reason I didn't decide to just fix up and submit what I had but was trying to fix everything in the area).

Also, briefly looking back at the cover letter and thread overview it looks like no one ever attempted to shed light on the question I asked in my RFC about what correct behavior was for one special case (i.e. whether patches 5 & 6 of that series should be kept or whether they should be dropped and patch 7 should be squashed into earlier patches). Anyone have thoughts on that?

Elijah
Previous: Rafael Ascensão
Message 3 of 3 in “[bug?] clean: Demonstrate failure when used with paths”
  1. Rafael AscensãoMay 31, 2019
  2. Rafael AscensãoJun 3, 2019
  3. Elijah NewrenJun 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.