git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jan 2022, #03; Thu, 13)

From
Elijah Newren <newren@gmail.com>
Date
Jan 14, 2022, 16:27 UTC
Message-ID
<CABPp-BFGxKBzi5RYDuiJv6Vz7yyGYTOdJC9cL_EkPGNJ5BksYQ@mail.gmail.com>
In-Reply-To
<xmqqk0f3dk5o.fsf@gitster.g>
On Fri, Jan 14, 2022 at 8:19 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 27 quoted lines
>
> Junio C Hamano <gitster@pobox.com> writes:
>
> > There are a few "oops, what we merged recently is broken" topics
> > that still are not in 'master', but otherwise what we have should
> > be pretty much what we'll have in the final one.
> >
> >  - I am reasonably happy with ab/refs-errno-cleanup (just one patch)
> >    that fixes the incorrect state of the code left by the earlier
> >    parts of the topic that have already been merged during this
> >    cycle.
> >
> >  - I am also OK with ab/reftable-build-fixes (two patches), one for
> >    general type correctness fix, the other for helping older sub-C99
> >    compilers.
> >
> > If there are fixes for regressions that we introduced during this
> > cycle other than these two topics, I certainly am missing them, so
> > please holler loudly and quickly, hopefully in time for me to tag
> > the -rc1 tomorrow.
>
> Oh, by the way, the tip of 'seen' has consistently failing the
> leak-check test.  I didn't have chance, time or energy to see if
> they are failing merely because an existing test script that used to
> be leak-clean gained a use of command that has been known to be
> leak-unclean without introducing any new leaks, or our recent change
> did introduce new leaks to commands that have been leak-clean.

It's apparently the latter, because there have been no test script changes in the relevant tests.

> Somebody with too much time on their hand should go in and check to
> help, before CI testing on 'seen' becomes useful again.

This "fixes" seen: https://lore.kernel.org/git/pull.1192.git.git.1642176433017.gitgitgadget@gmail.com/

I briefly looked at a couple leak traces and thought they looked ref related, but I don't have time to go hunt down memory leaks right now. I figure this thread has reported them, so let's just get "seen" back to green.

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 19 in “What's cooking in git.git (Jan 2022, #03; Thu, 13)”
  1. Junio C HamanoJan 14, 2022
  2. Junio C HamanoJan 14, 2022
  3. Elijah NewrenJan 14, 2022
  4. Junio C HamanoJan 14, 2022
  5. Elijah NewrenJan 14, 2022
  6. Junio C HamanoJan 14, 2022
  7. Junio C HamanoJan 14, 2022
  8. Ævar Arnfjörð BjarmasonJan 14, 2022
  9. Patrick SteinhardtJan 17, 2022
  10. Mistakes in the stalled category? (Was: Re: What's cooking in git.git (Jan 2022, #03; Thu, 13))Elijah Newren, Jan 14, 2022
  11. Junio C HamanoJan 14, 2022
  12. Junio C HamanoJan 14, 2022
  13. Junio C HamanoJan 15, 2022
  14. Derrick StoleeJan 18, 2022
  15. en/present-despite-skipped & en/remerge-diff (Was: Re: What's cooking in git.git (Jan 2022, #03; Thu, 13))Elijah Newren, Jan 14, 2022
  16. tb/midx-bitmap-corruption-fix (was: Re: What's cooking in git.git (Jan 2022, #03; Thu, 13))Taylor Blau, Jan 14, 2022
  17. David AguilarJan 15, 2022
  18. Junio C HamanoJan 15, 2022
  19. David AguilarJan 16, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.