Re: [PATCH] trace2: log progress time and throughput

From: Elijah Newren <newren@gmail.com>
Date: Jun 21, 2021, 13:55 UTC
Message-ID: <CABPp-BFDfCqpDGZ1D=U6V5--KkcuCJON5-CcX-PVLcvH4pc5cg@mail.gmail.com>
In-Reply-To: <871r8w3sxu.fsf@evledraar.gmail.com>

On Sun, Jun 20, 2021 at 6:32 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 15 quoted lines

>
> On Tue, May 12 2020, Emily Shaffer wrote:
>
> [Replying to a change long-since merged into git.git's "master"]
>
> > Rather than teaching only one operation, like 'git fetch', how to write
> > down throughput to traces, we can learn about a wide range of user
> > operations that may seem slow by adding tooling to the progress library
> > itself. Operations which display progress are likely to be slow-running
> > and the kind of thing we want to monitor for performance anyways. By
> > showing object counts and data transfer size, we should be able to
> > make some derived measurements to ensure operations are scaling the way
> > we expect.
>
> Did you end up using this data for anything?

I know you were asking Emily, but independently, I found it useful while doing merge-ort and diffcore-rename optimizations. I thought it was a clever idea for quickly adding more measurement regions easily, and wished I had thought of it myself earlier.