Re: [PATCH 0/3] Fix stash apply in sparse checkouts (and a submodule test)

From: Elijah Newren <newren@gmail.com>
Date: Nov 26, 2020, 05:31 UTC
Message-ID: <CABPp-BF5GgpXdo+8TwBPPtxJWot+6h+9oLkWMTtiiqy_uNDKMw@mail.gmail.com>
In-Reply-To: <xmqqlfepcceq.fsf@gitster.c.googlers.com>

On Wed, Nov 25, 2020 at 2:14 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 22 quoted lines

>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > Heavier usage of sparse-checkouts at $DAYJOB is commencing. And an issue
> > with git stash apply was found.
> >
> > git stash's implementation as a pipeline of forked commands presents some
> > problems, especially when implemented atop of three commands that all behave
> > differently in the presence of sparse checkouts. Add a testcase
> > demonstrating some issues with git stash apply in a repository with a
> > different set of sparse-checkout patterns at apply vs create time, clean up
> > the relevant section of git stash code, and incidentally fix a submodule
> > testcase unrelated to sparse checkouts. Provide some detailed commit
> > messages explaining the issues along the way.
> >
> > NOTE: I found a couple minor issues with other commands in sparse checkouts
> > while debugging this issue, but I don't yet have fixes for them and I can
> > submit them separately.
>
> Any comments on this from reviewers?  The second patch is a but too
> busy looking and I am having a bit of trouble convincing myself that
> it is doing the right thing.

Hmm, that diff is a little hard to read. It's a removal of two functions, and an addition of a new one, but the way the diff reads it looks like I'm modifying the existing functions because it catches some comment line markers and thinks they're similar. Maybe it'd be easier to read if I inserted that function elsewhere in the file?

I'll send a re-roll with that and add a comment or two to help explain it (as well as fix up the small issues Chris highlighted).