Re: [RFC PATCH] fast-export, fast-import: Let tags specify an internal name
- From
Elijah Newren <newren@gmail.com>
- Date
- Apr 21, 2021, 19:32 UTC
- Message-ID
- <CABPp-BF373j2BbyTgTJbKzDP9Y5R2jZVNqWeOqLtypdz6VZRMQ@mail.gmail.com>
- In-Reply-To
- <xmqqy2dbxybn.fsf@gitster.g>
On Wed, Apr 21, 2021 at 11:54 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> > Elijah Newren <newren@gmail.com> writes: > > > On Tue, Apr 20, 2021 at 2:40 PM Junio C Hamano <gitster@pobox.com> wrote: > >> ... > >> +The `<refname>` is prefixed with `refs/tags/` when stored > >> in Git, so importing the CVS branch symbol `RELENG-1_0-FINAL` would > >> -use just `RELENG-1_0-FINAL` for `<name>`, and fast-import will write the > >> +use just `RELENG-1_0-FINAL` for `<refname>`, and fast-import will write the > >> corresponding ref as `refs/tags/RELENG-1_0-FINAL`. > > > > Going on a slight tangent since you didn't introduce this, but since > > you're modifying this exact documentation... > > > > I hate the assumed "refs/tags/" prefix. Especially since ... > > ... The special casing reminds me of the ref-updated hook in > > gerrit > > Gerrit and fast-import? What is common is Shawn, perhaps ;-)?
:-) To be fair, though, given the number of things he created for us, it's inevitable there'd be a few small things causing problems and these are small potatoes in the big scheme of things. ref-updated was fixed years ago, and it sounds like Luke is about to fix the tag prefix assumption for us.
Show 6 quoted lines
> > broken given the fact that the name inside the tag didn't match the > > name of the actual ref. (To be honest, though, I was never sure why > > the name of the tag was recorded inside the tag itself.) > > The name of the tag and the name of the object has to be together > for a signature over it to have any meaning, no?
Oh, I guess if you treat the signature as affirming that not only do you like the object but that it has a particular nickname, then yes you'd need both. I had always viewed a signed tag as an affirmation that the object was good/tested/verified/whatever, and viewed the nickname of that good object as ancillary. I have to admit to not using signed tags much, though.