git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] t/t5329-pack-objects-cruft.sh: evict 'repack'-related tests

From
Elijah Newren <newren@gmail.com>
Date
Mar 19, 2025, 14:20 UTC
Message-ID
<CABPp-BF1ivo2+tR0-KnU-KF6omtswp-ZMWiBgWPmmgOaRu8RhQ@mail.gmail.com>
In-Reply-To
<0aa8aa65c130fd62d38b4944c1ce2a97451b0064.1742252411.git.me@ttaylorr.com>
On Mon, Mar 17, 2025 at 4:00 PM Taylor Blau <me@ttaylorr.com> wrote:
Show 24 quoted lines
>
> The cruft pack feature has two primary test scripts which exercise
> various parts of it, which are:
>
>   - t5329-pack-objects-cruft.sh
>   - t7704-repack-cruft.sh
>
> The former is designed to test low-level pack generation mechanics at
> the 'git pack-objects --cruft'-level, which is plumbing. The latter, on
> the other hand, is designed to test the user-facing behavior through
> 'git repack --cruft', which is porcelain (under the "ancillary
> manipulators" sub-section).
>
> At some point a handful of tests which should have been added to the
> latter script were instead written to the former. This isn't a huge
> deal, but rectifying it is straightforward. Move a handful of
> 'repack'-related tests out of t5329 and into their rightful home in
> t7704.
>
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
> ---
>  t/t5329-pack-objects-cruft.sh | 250 ----------------------------------
>  t/t7704-repack-cruft.sh       | 250 ++++++++++++++++++++++++++++++++++
>  2 files changed, 250 insertions(+), 250 deletions(-)

A quick view with --color-moved makes it easy to verify that the tests simply moved.

Previous: Taylor BlauNext: Taylor Blau
Message 3 of 19 in “repack: introduce '--combine-cruft-below-size'”
  1. 0/5 repack: introduce '--combine-cruft-below-size'Taylor Blau, Mar 17, 2025
  2. 1/5 t/t5329-pack-objects-cruft.sh: evict 'repack'-related testsTaylor Blau, Mar 17, 2025
  3. Elijah NewrenMar 19, 2025
  4. 2/5 t/t7704-repack-cruft.sh: clarify wording in --max-cruft-size testsTaylor Blau, Mar 17, 2025
  5. Elijah NewrenMar 19, 2025
  6. 3/5 t/t7704-repack-cruft.sh: consolidate `write_blob()`Taylor Blau, Mar 17, 2025
  7. 4/5 repack: avoid combining cruft packs with `--max-cruft-size`Taylor Blau, Mar 17, 2025
  8. 5/5 repack: begin combining cruft packs with `--combine-cruft-below-size`Taylor Blau, Mar 17, 2025
  9. Junio C HamanoMar 18, 2025
  10. Taylor BlauMar 19, 2025
  11. Elijah NewrenMar 19, 2025
  12. Taylor BlauMar 19, 2025
  13. 0/5 repack: introduce '--combine-cruft-below-size'Taylor Blau, Mar 19, 2025
  14. 1/5 t/t5329-pack-objects-cruft.sh: evict 'repack'-related testsTaylor Blau, Mar 19, 2025
  15. 2/5 t/t7704-repack-cruft.sh: clarify wording in --max-cruft-size testsTaylor Blau, Mar 19, 2025
  16. 3/5 t/t7704-repack-cruft.sh: consolidate `write_blob()`Taylor Blau, Mar 19, 2025
  17. 4/5 repack: avoid combining cruft packs with `--max-cruft-size`Taylor Blau, Mar 19, 2025
  18. 5/5 repack: begin combining cruft packs with `--combine-cruft-below-size`Taylor Blau, Mar 19, 2025
  19. Elijah NewrenMar 20, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.