git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/7] add/rm: honor sparse checkout and warn on sparse paths

From
Elijah Newren <newren@gmail.com>
Date
Mar 13, 2021, 07:07 UTC
Message-ID
<CABPp-BEriPaDY=84=j0tT62+U93jKePTyTKPZA4+dYtSFJaSTg@mail.gmail.com>
In-Reply-To
<cover.1615588108.git.matheus.bernardino@usp.br>

On Fri, Mar 12, 2021 at 2:48 PM Matheus Tavares <matheus.bernardino@usp.br> wrote:

Show 26 quoted lines
>
> Make `rm` honor sparse checkouts, and make both `rm` and `add` warn
> when they are asked to update sparse entries.
>
> Main changes since v2:
>
> Patch 2:
> - Removed unnecessary `rm` in t3705's auxiliary function and added
>   comment about why `update-index --force-remove` is used there.
>
> Patch 4:
> - Replaced the boolean function parameter with a more descriptive enum.
>   This way, readers don't have to go to the function definition to
>   understand what the caller wants.
>
> Patches 5 and 6:
> - Reworded both commit messages and the advice.updateSparsePath docs to
>   avoid saying "pathspecs that *only* match sparse entries", as the
>   situations to which they refer might also include matches among
>   ignored paths.
> - Rephrased the warning message about sparse paths so that it doesn't
>   contradict the message on ignored paths when they are displayed
>   together.
>
> Patch 7:
> - Adjusted the tests to check for the new sparse warning message.

v2 already looked pretty good to me; even if I still had lots of little comments on that series. This version addresses all my remaining concerns with v2. So this gets my:

Reviewed-by: Elijah Newren <newren@gmail.com>
Thanks for all your work on this!
Previous: Derrick StoleeNext: Matheus Tavares
Message 19 of 32 in “add/rm: honor sparse checkout and warn on sparse paths”
  1. 0/7 add/rm: honor sparse checkout and warn on sparse pathsMatheus Tavares, Mar 12, 2021
  2. 2/7 t3705: add tests for `git add` in sparse checkoutsMatheus Tavares, Mar 12, 2021
  3. Derrick StoleeMar 23, 2021
  4. 1/7 add: include magic part of pathspec on --refresh errorMatheus Tavares, Mar 12, 2021
  5. 4/7 pathspec: allow to ignore SKIP_WORKTREE entries on index matchingMatheus Tavares, Mar 12, 2021
  6. 5/7 refresh_index(): add REFRESH_DONT_MARK_SPARSE_MATCHES flagMatheus Tavares, Mar 12, 2021
  7. Junio C HamanoMar 18, 2021
  8. Junio C HamanoMar 19, 2021
  9. Matheus Tavares BernardinoMar 19, 2021
  10. Junio C HamanoMar 19, 2021
  11. Matheus Tavares BernardinoMar 30, 2021
  12. Elijah NewrenMar 31, 2021
  13. 3/7 add: make --chmod and --renormalize honor sparse checkoutsMatheus Tavares, Mar 12, 2021
  14. 6/7 add: warn when asked to update SKIP_WORKTREE entriesMatheus Tavares, Mar 12, 2021
  15. 7/7 rm: honor sparse checkout patternsMatheus Tavares, Mar 12, 2021
  16. Ævar Arnfjörð BjarmasonMar 21, 2021
  17. Matheus Tavares BernardinoMar 22, 2021
  18. Derrick StoleeMar 23, 2021
  19. Elijah NewrenMar 13, 2021
  20. 0/7 add/rm: honor sparse checkout and warn on sparse pathsMatheus Tavares, Apr 8, 2021
  21. 1/7 add: include magic part of pathspec on --refresh errorMatheus Tavares, Apr 8, 2021
  22. 2/7 t3705: add tests for `git add` in sparse checkoutsMatheus Tavares, Apr 8, 2021
  23. Derrick StoleeApr 14, 2021
  24. 3/7 add: make --chmod and --renormalize honor sparse checkoutsMatheus Tavares, Apr 8, 2021
  25. 4/7 pathspec: allow to ignore SKIP_WORKTREE entries on index matchingMatheus Tavares, Apr 8, 2021
  26. 5/7 refresh_index(): add flag to ignore SKIP_WORKTREE entriesMatheus Tavares, Apr 8, 2021
  27. 6/7 add: warn when asked to update SKIP_WORKTREE entriesMatheus Tavares, Apr 8, 2021
  28. 7/7 rm: honor sparse checkout patternsMatheus Tavares, Apr 8, 2021
  29. Elijah NewrenApr 14, 2021
  30. Matheus Tavares BernardinoApr 14, 2021
  31. Junio C HamanoApr 16, 2021
  32. Elijah NewrenApr 16, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.