git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/15] leak tests: remaining non-svn non-p4 tests as passing

From
Elijah Newren <newren@gmail.com>
Date
Nov 15, 2021, 22:14 UTC
Message-ID
<CABPp-BEokunZkv2zZ6UGBDouNwjPpWhha7gdwW0OqV8N+f1yPA@mail.gmail.com>
In-Reply-To
<cover-00.15-00000000000-20211030T221945Z-avarab@gmail.com>

On Sat, Oct 30, 2021 at 3:24 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 144 quoted lines
>
> A follow-up to the now-landed series[1] to mark various tests as
> passing under SANITIZE=leak.
>
> Existing passing tests were found with:
>
>     rm .prove; GIT_SKIP_TESTS=t0027 prove -j8 --state=save t[0-9]*.sh :: --immediate
>     GIT_TEST_PASSING_SANITIZE_LEAK=true prove -j8 --state=passed
>
> These are all the tests that aren't "git-svn", "git-p4",
> Windows-specific, or icase, need to write to / etc.
>
> As before I've merged this to "seen" and all tests pass with whatever
> we've got in-flight at the moment, so this should cause minimal
> disruption. Passing CI run on top of "master" at [2].
>
> 1. https://lore.kernel.org/git/cover-v2-0.9-00000000000-20211012T135343Z-avarab@gmail.com/
> 2. https://github.com/avar/git/actions/runs/1403093377
>
> Ævar Arnfjörð Bjarmason (15):
>   leak tests: mark a read-tree test as passing SANITIZE=leak
>   leak tests: mark "sort" test as passing SANITIZE=leak
>   leak tests: mark most gettext tests as passing with SANITIZE=leak
>   leak tests: mark some misc tests as passing with SANITIZE=leak
>   leak tests: mark some rev-list tests as passing with SANITIZE=leak
>   leak tests: mark some rev-parse tests as passing with SANITIZE=leak
>   leak tests: mark some update-index tests as passing with SANITIZE=leak
>   leak tests: mark some notes tests as passing with SANITIZE=leak
>   leak tests: mark some apply tests as passing with SANITIZE=leak
>   leak tests: mark some diff tests as passing with SANITIZE=leak
>   leak tests: mark some add tests as passing with SANITIZE=leak
>   leak tests: mark some clone tests as passing with SANITIZE=leak
>   leak tests: mark some status tests as passing with SANITIZE=leak
>   leak tests: mark some config tests as passing with SANITIZE=leak
>   leak tests: mark some fast-import tests as passing with SANITIZE=leak
>
>  t/t0071-sort.sh                             | 1 +
>  t/t0200-gettext-basic.sh                    | 1 +
>  t/t0201-gettext-fallbacks.sh                | 1 +
>  t/t0202-gettext-perl.sh                     | 1 +
>  t/t0204-gettext-reencode-sanity.sh          | 1 +
>  t/t1002-read-tree-m-u-2way.sh               | 2 ++
>  t/t1300-config.sh                           | 1 +
>  t/t1303-wacky-config.sh                     | 2 ++
>  t/t1307-config-blob.sh                      | 2 ++
>  t/t1308-config-set.sh                       | 1 +
>  t/t1309-early-config.sh                     | 1 +
>  t/t1310-config-default.sh                   | 1 +
>  t/t1420-lost-found.sh                       | 2 ++
>  t/t1503-rev-parse-verify.sh                 | 1 +
>  t/t1506-rev-parse-diagnosis.sh              | 1 +
>  t/t1513-rev-parse-prefix.sh                 | 1 +
>  t/t1515-rev-parse-outside-repo.sh           | 2 ++
>  t/t1600-index.sh                            | 1 +
>  t/t2000-conflict-when-checking-files-out.sh | 1 +
>  t/t2100-update-cache-badpath.sh             | 1 +
>  t/t2101-update-index-reupdate.sh            | 1 +
>  t/t2102-update-index-symlinks.sh            | 1 +
>  t/t2103-update-index-ignore-missing.sh      | 1 +
>  t/t2104-update-index-skip-worktree.sh       | 1 +
>  t/t2105-update-index-gitfile.sh             | 1 +
>  t/t2200-add-update.sh                       | 1 +
>  t/t2201-add-update-typechange.sh            | 1 +
>  t/t2202-add-addremove.sh                    | 1 +
>  t/t2204-add-ignored.sh                      | 1 +
>  t/t2404-worktree-config.sh                  | 1 +
>  t/t3302-notes-index-expensive.sh            | 1 +
>  t/t3303-notes-subtrees.sh                   | 1 +
>  t/t3320-notes-merge-worktrees.sh            | 1 +
>  t/t3702-add-edit.sh                         | 2 ++
>  t/t3703-add-magic-pathspec.sh               | 1 +
>  t/t3704-add-pathspec-file.sh                | 1 +
>  t/t3908-stash-in-worktree.sh                | 1 +
>  t/t4000-diff-format.sh                      | 2 ++
>  t/t4003-diff-rename-1.sh                    | 2 ++
>  t/t4004-diff-rename-symlink.sh              | 2 ++
>  t/t4005-diff-rename-2.sh                    | 2 ++
>  t/t4006-diff-mode.sh                        | 2 ++
>  t/t4007-rename-3.sh                         | 2 ++
>  t/t4009-diff-rename-4.sh                    | 2 ++
>  t/t4010-diff-pathspec.sh                    | 2 ++
>  t/t4011-diff-symlink.sh                     | 2 ++
>  t/t4012-diff-binary.sh                      | 1 +
>  t/t4020-diff-external.sh                    | 1 +
>  t/t4024-diff-optimize-common.sh             | 1 +
>  t/t4027-diff-submodule.sh                   | 1 +
>  t/t4029-diff-trailing-space.sh              | 1 +
>  t/t4032-diff-inter-hunk-context.sh          | 1 +
>  t/t4033-diff-patience.sh                    | 1 +
>  t/t4034-diff-words.sh                       | 1 +
>  t/t4035-diff-quiet.sh                       | 1 +
>  t/t4037-diff-r-t-dirs.sh                    | 1 +
>  t/t4040-whitespace-status.sh                | 2 ++
>  t/t4046-diff-unmerged.sh                    | 2 ++
>  t/t4049-diff-stat-count.sh                  | 2 ++
>  t/t4050-diff-histogram.sh                   | 1 +
>  t/t4054-diff-bogus-tree.sh                  | 2 ++
>  t/t4062-diff-pickaxe.sh                     | 1 +
>  t/t4063-diff-blobs.sh                       | 2 ++
>  t/t4100-apply-stat.sh                       | 2 ++
>  t/t4101-apply-nonl.sh                       | 2 ++
>  t/t4102-apply-rename.sh                     | 2 ++
>  t/t4105-apply-fuzz.sh                       | 2 ++
>  t/t4106-apply-stdin.sh                      | 2 ++
>  t/t4109-apply-multifrag.sh                  | 2 ++
>  t/t4110-apply-scan.sh                       | 2 ++
>  t/t4112-apply-renames.sh                    | 2 ++
>  t/t4116-apply-reverse.sh                    | 2 ++
>  t/t4118-apply-empty-context.sh              | 2 ++
>  t/t4119-apply-config.sh                     | 2 ++
>  t/t4123-apply-shrink.sh                     | 2 ++
>  t/t4126-apply-empty.sh                      | 2 ++
>  t/t4127-apply-same-fn.sh                    | 2 ++
>  t/t4128-apply-root.sh                       | 2 ++
>  t/t4129-apply-samemode.sh                   | 2 ++
>  t/t4130-apply-criss-cross-rename.sh         | 2 ++
>  t/t4132-apply-removal.sh                    | 2 ++
>  t/t4133-apply-filenames.sh                  | 2 ++
>  t/t4134-apply-submodule.sh                  | 2 ++
>  t/t4136-apply-check.sh                      | 2 ++
>  t/t4139-apply-escape.sh                     | 2 ++
>  t/t5002-archive-attr-pattern.sh             | 1 +
>  t/t5200-update-server-info.sh               | 1 +
>  t/t5307-pack-missing-commit.sh              | 1 +
>  t/t5555-http-smart-common.sh                | 1 +
>  t/t5602-clone-remote-exec.sh                | 1 +
>  t/t5603-clone-dirname.sh                    | 2 ++
>  t/t5701-git-serve.sh                        | 1 +
>  t/t5704-protocol-violations.sh              | 2 ++
>  t/t6005-rev-list-count.sh                   | 1 +
>  t/t6102-rev-list-unexpected-objects.sh      | 1 +
>  t/t6136-pathspec-in-bare.sh                 | 1 +
>  t/t7101-reset-empty-subdirs.sh              | 2 ++
>  t/t7103-reset-bare.sh                       | 2 ++
>  t/t7511-status-index.sh                     | 1 +
>  t/t7515-status-symlinks.sh                  | 1 +
>  t/t7525-status-rename.sh                    | 1 +
>  t/t7526-commit-pathspec-file.sh             | 1 +
>  t/t9302-fast-import-unpack-limit.sh         | 2 ++
>  t/t9303-fast-import-compression.sh          | 2 ++
>  104 files changed, 152 insertions(+)
>
> --
> 2.33.1.1570.g069344fdd45

Sorry for not responding earlier; you sent this on the day of our big migration (consolidating Git servers, reworking CI pipelines, etc.) at $DAYJOB. Anyway, I've now read through this series. It's simple and straightforward, helps us on our journey to clean up leaks and ensuring they stay clean (nice to see that this covers almost 5k tests), and I couldn't spot any problems. Thanks for working on this!

Reviewed-by: Elijah Newren <newren@gmail.com>
Previous: Ævar Arnfjörð Bjarmason
Message 17 of 17 in “leak tests: remaining non-svn non-p4 tests as passing”
  1. 00/15 leak tests: remaining non-svn non-p4 tests as passingÆvar Arnfjörð Bjarmason, Oct 30, 2021
  2. 02/15 leak tests: mark "sort" test as passing SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  3. 01/15 leak tests: mark a read-tree test as passing SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  4. 03/15 leak tests: mark most gettext tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  5. 05/15 leak tests: mark some rev-list tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  6. 04/15 leak tests: mark some misc tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  7. 07/15 leak tests: mark some update-index tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  8. 06/15 leak tests: mark some rev-parse tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  9. 08/15 leak tests: mark some notes tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  10. 09/15 leak tests: mark some apply tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  11. 10/15 leak tests: mark some diff tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  12. 11/15 leak tests: mark some add tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  13. 12/15 leak tests: mark some clone tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  14. 13/15 leak tests: mark some status tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  15. 14/15 leak tests: mark some config tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  16. 15/15 leak tests: mark some fast-import tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 30, 2021
  17. Elijah NewrenNov 15, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.