Re: [PATCH v3 00/11] Fix various issues around removal of untracked files/directories
- From
Elijah Newren <newren@gmail.com>
- Date
- Sep 27, 2021, 20:41 UTC
- Message-ID
- <CABPp-BESmz+9vcd0r+5MT8vr7HodecUpLKNL=Hyx4qxLJv0ZCA@mail.gmail.com>
- In-Reply-To
- <xmqq7df1pxgh.fsf@gitster.g>
On Mon, Sep 27, 2021 at 1:36 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> > "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > Changes since v2 (all due to Junio's request to consolidate > > unpack_trees_options.dir handling): > > Heh, don't blame me. I even explicitly said it was merely an > observation for longer term, not a suggestion to include the first > step for such a move in this series.
Well...the repetitive code for setting up and clearing out unpack_trees_options.dir that already existed (and which my series was copying to more places) bugged me too, but I was worried that it was a bit messy to clean up (and the fact that it took five patches suggests it was). But then you also brought it up as an issue when reviewing, so I figured I might as well dive in...