Re: [PATCH] multimail: stop shipping a copy

From: Elijah Newren <newren@gmail.com>
Date: Jun 10, 2021, 15:40 UTC
Message-ID: <CABPp-BEQs=n2YhZGVNvLAUVedO1rnWaM=DXYMvVwqDnst3s-sQ@mail.gmail.com>
In-Reply-To: <1554066605.61418500.1623333784687.JavaMail.zimbra@matthieu-moy.fr>

On Thu, Jun 10, 2021 at 7:03 AM Matthieu Moy <git@matthieu-moy.fr> wrote:

Show 17 quoted lines

>
> "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>:
>
> > On Thu, Jun 10 2021, Johannes Schindelin via GitGitGadget wrote:
> >
> > > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > > The multimail project is developed independently and has its own project
> > > page. Traditionally, we shipped a copy in contrib/.
> >
> > > However, such a copy is prone to become stale, and users are much better
> > > served to be directed to the actual project instead.
> >
> > Let's CC its maintainer / other people who've actively contributed to
> > it. I've taken the liberty to do that.
>
> Thanks.

I only authored ~2% of the commits in git-multimail, compared to Matthieu's ~55% and Michael's ~32%. So I'm not sure my opinion should matter, even if I had a strong opinion.

And I don't have a strong opinion. git-multimail was awesome and very helpful for a few years, but it did everything I needed as of 2015 and I didn't really contribute further because it was perfect for my needs by that point. (Well, okay, I did apparently contribute 563c41ed05ae (Ficks a phew simpul speling erors., 2019-11-04) after 2015, but those were just typo fixes in comments, not particularly important.)

Also, back when I did use it, I always used the version from upstream rather than the copy from git.

> > Having written a system in the past that made use of git-multimail.py
> > (and sourced it from git.git's copy) I'd think a better direction would
> > be to keep this and modify githooks(5) to actively recommend it over the
> > older and less featureful post-receive-email script.

Recommending git-multimail over the existing post-receive-email script makes a lot of sense; git-multimail is much, much better.

Show 7 quoted lines

> I'm all for recommending it in githooks, but this can be done by pointing
> to GitHub's URL instead of a local path. Actually the sample script could
> look like
>
> # Fetch git-multimail.py from https://github.com/git-multimail/git-multimail/
> # adapt and uncomment the following line:
> #exec /path/to/git_multimail.py

This seems like a good idea.