Re: What's cooking in git.git (May 2021, #02; Wed, 12)

From: Elijah Newren <newren@gmail.com>
Date: May 12, 2021, 16:35 UTC
Message-ID: <CABPp-BELhOx=Hi1i0GPDJoDGF_xY0UGmgn4w58v_9O=gkcb-kg@mail.gmail.com>
In-Reply-To: <xmqqo8dgfl8l.fsf@gitster.g>

On Wed, May 12, 2021 at 12:49 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> * en/dir-traversal (2021-05-12) 8 commits
>  - dir: update stale description of treat_directory()
>  - dir: traverse into untracked directories if they may have ignored subfiles
>  - dir: avoid unnecessary traversal into ignored directory
>  - t3001, t7300: add testcase showcasing missed directory traversal
>  - t7300: add testcase showing unnecessary traversal into ignored directory
>  - ls-files: error out on -i unless -o or -c are specified
>  - dir: report number of visited directories and paths with trace2
>  - dir: convert trace calls to trace2 equivalents
>
>  "git clean" and "git ls-files -i" had confusion around working on
>  or showing ignored paths inside an ignored directory, which has
>  been corrected.
>
>  Will merge to 'next'?

Jeff had a couple small requests with the trace2 statistics, and I'll add a patch to fix read_cached_dir() to skip '.' and '..' entries as you suggested (and simplify various places in the code that do that already by introducing a helper function). So let me send out one last reroll.