Re: [RFC PATCH 0/2] merge-recursive: optimize time complexity

From: Elijah Newren <newren@gmail.com>
Date: Feb 13, 2025, 18:30 UTC
Message-ID: <CABPp-BEC3UVQcJfXLia6+XrmNCnozNdHtGhGOTUr4A9J=Xo1Ow@mail.gmail.com>
In-Reply-To: <20250213090040.16133-1-meetsoni3017@gmail.com>

Hi,

On Thu, Feb 13, 2025 at 1:01 AM Meet Soni <meetsoni3017@gmail.com> wrote:

Show 7 quoted lines

>
> changes in this version:
>     - Updated comment and commit message as per review.
>     - Added another commit implementing optimization logic.
>     - added an RFC tag since, if the changes in 2nd commit are
>       appropriate, we can apply similar logic in other places as
>       well.

The 1st patch looks good. The 2nd appears to have some problems, as per comments I left on it -- it might be easier to drop the second patch and just apply the first. I don't think merge-recursive is worth putting much effort into (there's value in providing feedback on patches by new contributors, because new contributors are valuable, but there's really not much value in tweaking this particular file), so I'd advise against adding more patches to this series that transform more of merge-recursive.