Re: [PATCH 3/5] pull: handle conflicting rebase/merge options via last option wins

From: Elijah Newren <newren@gmail.com>
Date: Jul 15, 2021, 20:40 UTC
Message-ID: <CABPp-BE8Qiu8Sdk8FD+UcAtZnToXFOv+Y+8Rwf3DyiZP6Te-SQ@mail.gmail.com>
In-Reply-To: <xmqqpmvjs61c.fsf@gitster.g>

On Thu, Jul 15, 2021 at 12:58 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

>
> Elijah Newren <newren@gmail.com> writes:
>
> > Let me ask two questions:
> >
> > 1. When is it beneficial for users to set both pull.ff and pull.rebase?
> > 2. Is it harmful to users for us to allow both to be set when we will
> > just ignore one?
> >
> > I believe the answer to (1) is "never", and the answer to (2) is "yes".
>
> I agree (1) never gives you anything, even though it does not hurt,
> and (2) is "meh".

Okay, let's drop this series then. Thanks for pointing out my mix-up on the rebase --no-ff thing in the other email.