Re: [PATCH v4 12/12] sequencer: notify user of --update-refs activity

From: Elijah Newren <newren@gmail.com>
Date: Jul 16, 2022, 22:09 UTC
Message-ID: <CABPp-BE++xWxWg5bJy9xj1i2QvFyGf+mKQvObdujNoPFU6M-Wg@mail.gmail.com>
In-Reply-To: <d5cd4b49e46bc2c186c6e89333360a975700c99a.1657631226.git.gitgitgadget@gmail.com>

On Tue, Jul 12, 2022 at 6:07 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 15 quoted lines

>
> From: Derrick Stolee <derrickstolee@github.com>
>
> When the user runs 'git rebase -i --update-refs', the end message still
> says only
>
>   Successfully rebased and updated <HEAD-ref>.
>
> Update the sequencer to collect the successful (and unsuccessful) ref
> updates due to the --update-refs option, so the end message now says
>
>   Successfully rebased and updated <HEAD-ref>.
>   Updated the following refs with --update-refs:
>         refs/heads/first
>         refs/heads/third

This seems good.

>   Failed to update the following refs with --update-refs:
>         refs/heads/second

This is good, but I think it could be improved. Could we also include the commit to which rebase would have updated the branch to? That would allow the user to manually update it if they want, or at least see a range-diff between what we would have updated it to and what it now has. Without that information, the user might have difficulty correcting that branch.

Anyway, I've only been able to find a few minor things in reviewing this series. It looks really good overall, and I'm sure lots of people will be making use of it!