Re: [PATCH/RFC] Makefile: do not depend on curl-config
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Apr 30, 2014, 13:08 UTC
- Message-ID
- <CABPQNSbvoYfUp6ZG8kMPPX5rcDetUCqunOGO2cX-yhPsGkCOTg@mail.gmail.com>
- In-Reply-To
- <1398702545-9860-1-git-send-email-kusmabite@gmail.com>
On Mon, Apr 28, 2014 at 6:29 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
Show 19 quoted lines
> MinGW builds of cURL does not ship with curl-config unless built > with the autoconf based build system, which is not the practice > recommended by the documentation. MsysGit has had issues with > binaries of that sort, so it has switched away from autoconf-based > cURL-builds. > > Unfortunately, broke pushing over WebDAV on Windows, because > http-push.c depends on cURL's multi-threaded API, which we could > not determine the presence of any more. > > Since troublesome curl-versions are ancient, and not even present > in RedHat 5, let's just assume cURL is capable instead of doing a > non-robust check. > > Instead, add a check for curl_multi_init to our configure-script, > for those on ancient system. They probably already need to do the > configure-dance anyway. > > Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Junio,
this patch still applies, and is required on Git for Windows for http-push to work, even after f3f11fa ("Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR").
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.