Re: [PATCH v2] contrib: add win32 credential-helper
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Apr 23, 2012, 16:05 UTC
- Message-ID
- <CABPQNSawsoheM6Qoxs-iQ-KYxYFs-s60oFLzdyRDFT0o=KXt1w@mail.gmail.com>
- In-Reply-To
- <20120422180716.GA27339@sigill.intra.peff.net>
On Sun, Apr 22, 2012 at 8:07 PM, Jeff King <peff@peff.net> wrote:
Show 13 quoted lines
> On Thu, Apr 19, 2012 at 08:45:22PM +0200, Erik Faye-Lund wrote: > >> Here's an updated version of my Windows credential-helper. > > Sorry, I've been traveling and haven't had a chance to look at this > in-depth yet. I'll do so next week. In the meantime, I wanted to point > out this similar project: > > https://github.com/anurse/git-credential-winstore > > which somebody else pointed me to a few days ago. I don't know yet if > your approaches are the same, or if it would be worth combining efforts > or not.
Yeah, I saw that one a couple of days ago myself.
They use the same credential store, and I actually tried to make sure they can use the same data.
But apart from that, they work quite differently. My credential-helper only does storage, and passes the test-suite. The one you linked to seems to ignore any password being sent to it, and instead prompts the user if it doesn't already have a credential. It also does not seem to support storing credentials for multiple users for a domain/path.
But probably the biggest problem for Git for Windows is that it's written in C#, and we don't have a C# compiler in our tool-chain.
So I don't think there's much I can use from that helper, and I think my helper is in a healthier state. But I'm obviously biased.
-- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en