Re: [PATCH] Fix in Git.pm cat_blob crashes on large files (reviewed by Jeff King)

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Feb 22, 2013, 17:10 UTC
Message-ID: <CABPQNSaGSOio1Sn=--jdCfOkw4N+L_khH3Z6AZAQ=aaUg_OGig@mail.gmail.com>
In-Reply-To: <CAMB+bfLjewgKjSN6WNHGkwpRx9OaWipi_-TDa0MnJMDN+6tPZA@mail.gmail.com>

On Fri, Feb 22, 2013 at 6:03 PM, Joshua Clayton <stillcompiling@gmail.com> wrote:

Show 8 quoted lines

> Read and write each 1024 byte buffer, rather than trying to buffer
> the entire content of the file.
> Previous code would crash on all files > 2 Gib, when the offset variable
> became negative (perhaps below the level of perl), resulting in a crash.
> On a 32 bit system, or a system with low memory it might crash before
> reaching 2 GiB due to memory exhaustion.
>
> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>

We usually put "Reviewed-by: Name <email>" right below the SoB-line, rather than in the subject. And then we CC the people who were involved in the previous round :)