Re: [PATCH master] convert: The native line-ending is \r\n on MinGW
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Apr 15, 2013, 21:20 UTC
- Message-ID
- <CABPQNSaA7Qdt5eCZR3rs87gL730Y_xMrg6S-++YuaXdC2k45jg@mail.gmail.com>
- In-Reply-To
- <7v4nf7qzkd.fsf@alter.siamese.dyndns.org>
On Mon, Apr 15, 2013 at 11:00 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 46 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> Jonathan Nieder <jrnieder@gmail.com> writes: >> >>> If you try this: >>> >>> 1. Install Git for Windows (from the msysgit project) >>> 2. Put >>> >>> [core] >>> autocrlf = false >>> eol = native >>> >>> in your .gitconfig. >>> 3. Clone a project with >>> >>> *.txt text >>> >>> in its .gitattributes. >>> >>> Then with current git, any text files checked out have LF line >>> endings, instead of the expected CRLF. >>> >>> Cc: Johannes Schindelin <johannes.schindelin@gmx.de> >>> Cc: Johannes Sixt <j6t@kdbg.org> >>> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> >>> --- >>> Eyvind Bernhardsen wrote: >>> >>>> Introduce a new configuration variable, "core.eol", that allows the user >>>> to set which line endings to use for end-of-line-normalized files in the >>>> working directory. It defaults to "native", which means CRLF on Windows >>>> and LF everywhere else. >>> >>> The following fixup has been sitting in my tree (but not tested on >>> Windows) for a couple of weeks. Sensible? >>> >>> I don't know what the right choice for Cygwin is; probably LF unless >>> there is some way to detect the systemwide setting at run time. >> >> Has anybody in Windows land any input? I don't think what I do before >> 1.7.3 in my tree would matter much, so I am not applying this myself. > > Pinging MsysGit folk again ... > >
This is absolutely the right thing to do. However, stuff have changed a bit since the patch was written; this change now needs to go in config.mak.uname instead of config.mak.