Re: git_getpass regression?

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Jul 3, 2012, 17:37 UTC
Message-ID: <CABPQNSZjZtRxf1=cdKqgp3FwP6Fw2W876si9=OpyHmZ6mjHRsw@mail.gmail.com>
In-Reply-To: <20120703171121.GA3294@sigill.intra.peff.net>

On Tue, Jul 3, 2012 at 7:11 PM, Jeff King <peff@peff.net> wrote:

Show 11 quoted lines

> On Tue, Jul 03, 2012 at 06:28:11PM +0200, Erik Faye-Lund wrote:
>
>> Is there some other way of getting EOF from the console than Ctrl+C?
>> If not, perhaps we can disable the Ctrl+C handling altogether for the
>> current process, and restore the console mode on EOF? That only leaves
>> the "Bash kills our process"-case, but Bash seems to set a sane
>> console mode anyway.
>
> On unix systems, you can generally send EOF on a terminal using Ctrl+D
> (and strbuf_getline should handle it properly).  I have no clue if that
> works on a Windows console, though.

Nope. On Windows, Ctrl+D seens to give EOT (0x4).

> Also, I wonder if these kind of
> terminal issues are different based on the terminal emulator you are
> using (e.g., msys bash window versus something like pterm).

No, they should not. Windows doesn't have a concept of different terminal emulators. There's only ever one, which is built into windows.