Re: [PATCH/RFC] add lame win32 credential-helper

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Sep 15, 2011, 21:48 UTC
Message-ID: <CABPQNSZjGzyxJKWRDDWxRj_SLdC1Y_9TxnAMOA+b-Pw3+X-E7w@mail.gmail.com>
In-Reply-To: <20110915214026.GA18623@sigill.intra.peff.net>

On Thu, Sep 15, 2011 at 11:40 PM, Jeff King <peff@peff.net> wrote:

Show 11 quoted lines

> On Thu, Sep 15, 2011 at 10:25:24PM +0200, Erik Faye-Lund wrote:
>
>> Not that it's useful yet, since the core-git code for the
>> credential-helper support doesn't compile on Windows. So
>> it's not fully tested, I've only read the interface
>> documentation and experimented with it from the command
>> line.
>
> Which parts of the credential-helper code don't compile? I wouldn't be
> surprised if the cache helper doesn't work (because it uses unix domain
> sockets for communication).

That's exactly it:

unix-socket.c:12: warning: 'struct sockaddr_un' declared inside parameter list unix-socket.c:12: warning: its scope is only this definition or declaration, whi ch is probably not what you want unix-socket.c: In function 'unix_sockaddr_init': unix-socket.c:15: error: dereferencing pointer to incomplete type unix-socket.c:17: error: dereferencing pointer to incomplete type unix-socket.c:18: error: dereferencing pointer to incomplete type unix-socket.c:19: error: dereferencing pointer to incomplete type unix-socket.c: In function 'unix_stream_connect': unix-socket.c:25: error: storage size of 'sa' isn't known unix-socket.c: In function 'unix_stream_listen': unix-socket.c:39: error: storage size of 'sa' isn't known make: *** [unix-socket.o] Error 1 make: *** Waiting for unfinished jobs....

Show 5 quoted lines

> If it's too hard to adapt it to whatever IPC
> mechanism would be appropriate on Windows, we can just leave it out on
> that platform.
>
> But the core code in git itself should be pretty straight forward.

I didn't mean that it was impossible to port, just that it didn't compile as-is. I haven't looked into fixing up the code so it compiles on Windows again myself. And I'm not really planning to; I have little git-time these days, and little knowledge of how unix-sockets works...