Re: What's cooking in git.git (Aug 2012, #06; Sun, 19)

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Aug 20, 2012, 16:37 UTC
Message-ID: <CABPQNSZcyftefO1ikXRj6fqjDxwH1_6rwCLvt4z6Z4g6pGc-Ow@mail.gmail.com>
In-Reply-To: <7v8vd9ldxh.fsf@alter.siamese.dyndns.org>

On Mon, Aug 20, 2012 at 6:35 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 29 quoted lines

> Erik Faye-Lund <kusmabite@gmail.com> writes:
>
>> On Mon, Aug 20, 2012 at 6:21 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Erik Faye-Lund <kusmabite@gmail.com> writes:
>>>
>>>> On Mon, Aug 20, 2012 at 9:00 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>>>> * ef/win32-cred-helper (2012-08-16) 1 commit
>>>>>  - contrib: add win32 credential-helper
>>>>>
>>>>> Credential helper for Win32 (is this GUI???).
>>>>
>>>> No, and credential helpers shouldn't be either.
>>>
>>> Hrm, doesn't it even do "the application wants to access your
>>> keychain.  Allow it [Y/N]?" kind of thing?
>>>
>>
>> No. On Windows, you can freely access the keychain as long as a user
>> is logged in and the machine is not locked.
>
> OK, so is this a good description to go in the merge commit when it
> goes to 'master'?
>
>     * ef/win32-cred-helper (2012-08-16) 1 commit
>      - contrib: add win32 credential-helper
>
>      Credential helper for Win32, to allow access to the keychain of
>      logged-in user.
>

Looks good to me.