git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/1] index-pack: Disable threading on cygwin

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Jun 26, 2012, 21:00 UTC
Message-ID
<CABPQNSZ7=kqSjXPLior+LXqAt4AzcybOjJ1P8ZLQ+J-9gCgvdw@mail.gmail.com>
In-Reply-To
<7vk3ytc0es.fsf@alter.siamese.dyndns.org>
On Tue, Jun 26, 2012 at 9:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>
>>    - renamed FAKE_PREAD_NOT_THREAD_SAFE to NO_THREAD_SAFE_PREAD
>
> Sensible.
>
>>    - when NO_PREAD, set NO_THREAD_SAFE_PREAD in the Makefile, rather
>>      than in git-compat-util.h
>
> I think it is a bad change.  When compat/ pread gets improved to be
> thread-safe, this will surely be missed.

But CAN it be fixed? I don't think it could, at least not without wrapping ALL calls to functions that perform IO on file handles or file descriptors...

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “index-pack: Disable threading on cygwin”
  1. 1/1 index-pack: Disable threading on cygwinRamsay Jones, Jun 26, 2012
  2. Junio C HamanoJun 26, 2012
  3. Erik Faye-LundJun 26, 2012
  4. Junio C HamanoJun 26, 2012
  5. Erik Faye-LundJun 26, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.