Re: [PATCH 3/3] difftool: Disable --symlinks on cygwin

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Jul 26, 2012, 11:31 UTC
Message-ID: <CABPQNSZ=yWxVivadJfh9BMPtqiiGyyEL0vZu+fvsu_Zzhd7yhw@mail.gmail.com>
In-Reply-To: <1343186064-49350-4-git-send-email-davvid@gmail.com>

On Wed, Jul 25, 2012 at 5:14 AM, David Aguilar <davvid@gmail.com> wrote:

Show 21 quoted lines

> Symlinks are not ubiquitous on Windows so make --no-symlinks the default.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
> I don't have cygwin so I can't verify this one myself.
> Is 'cygwin' really the value of $^O there?
>
>  git-difftool.perl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/git-difftool.perl b/git-difftool.perl
> index 591ee75..10d3d97 100755
> --- a/git-difftool.perl
> +++ b/git-difftool.perl
> @@ -291,7 +291,8 @@ sub main
>                 gui => undef,
>                 help => undef,
>                 prompt => undef,
> -               symlinks => $^O ne 'MSWin32' && $^O ne 'msys',
> +               symlinks => $^O ne 'cygwin' &&
> +                               $^O ne 'MSWin32' && $^O ne 'msys',

I thought Cygwin supported (their own version of) symlinks? What's the rationale for not using it by default there?