Re: [PATCH v4 4/4] make poll() work on platforms that can't recv() on a non-socket

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Sep 8, 2012, 11:31 UTC
Message-ID: <CABPQNSY1+3X3LE19mSm2398Kr9EvOxbmsoRLzo4fFTytiA3B+Q@mail.gmail.com>
In-Reply-To: <004201cd8d0f$8e9ad4f0$abd07ed0$@schmitz-digital.de>

On Fri, Sep 7, 2012 at 5:43 PM, Joachim Schmitz <jojo@schmitz-digital.de> wrote:

Show 17 quoted lines

> This way it gets added to gnulib too.
>
> Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
> ---
>  compat/poll/poll.c | 5 +++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/compat/poll/poll.c b/compat/poll/poll.c
> index e4b8319..10a204e 100644
> --- a/compat/poll/poll.c
> +++ b/compat/poll/poll.c
> @@ -306,6 +306,10 @@ compute_revents (int fd, int sought, fd_set *rfds, fd_set *wfds, fd_set *efds)
>                || socket_errno == ECONNABORTED || socket_errno == ENETRESET)
>         happened |= POLLHUP;
>
> +      /* some systems can't use recv() on non-socket, including HP NonStop */
> +      else if (/* (r == -1) && */ socket_errno == ENOTSOCK)

Why add commented-out code ("(r == -1) && ")?