git diff --exit-code misbehaving in 2.46.x
- From
- Jan Wendland <jwend1703@gmail.com>
- Date
- Sep 25, 2024, 14:27 UTC
- Message-ID
- <CAB0mhhz9LHZ1AWSu_0oM=c89+z0w=XemnQwFAm45wp8zSmQ1Sw@mail.gmail.com>
Hey team,
git diff --exit-code in 2.46.x is unexpectedly returning a zero exit code for files marked as binary in .gitattributes where 2.45.x would correctly produce a non-zero exit code.
To reproduce: mkdir -p git-exit-code/dist cd git-exit-code git init echo "hi" > dist/main.js echo "dist/** binary" > .gitattributes git add --all git commit -m "Initial commit" echo "some change" >> dist/main.js git diff --exit-code echo $? # actual is 0, expected to be 1
Is this intended?
Kind regards Jan