Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly

From: Paolo Giarrusso <p.giarrusso@gmail.com>
Date: Oct 28, 2013, 14:04 UTC
Message-ID: <CAAcnjCRcU8L+F3BuGtm2c+XJxyVsROyY1pwVynK9qdvS8zfFZw@mail.gmail.com>

(Resending without HTML, so that it reaches the ML).

On Fri, Oct 11, 2013 at 11:32 AM, Paolo Giarrusso <p.giarrusso@gmail.com> wrote:

Show 16 quoted lines

>
> On Wed, Oct 9, 2013 at 11:11 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> > Paolo Giarrusso wrote:
> >
> >> Seeing the email, I wonder whether there's hope something like that
> >> can be preserved in an email, and whether the code should use some
> >> escape sequence instead.
> >
> > Yes, please.  Mind if I amend it to
> >
> >         printf "%s\r" "$revcount/$revmax ($createcount)" >&2
> >
> > ?
>
> Please do go ahead, by all means (arguably as a different commit, but
> those are minor details).

What happened? Did you go ahead, as you wrote? Is the patch somewhere? Arguably it should go into the maint branch, but I think it didn't — otherwise https://github.com/git/git/pull/61 should have stopped being mergeable.

This also makes me wonder whether you use any tracker at all — but unless there is one that I missed, that's a separate discussion.

Show 11 quoted lines

> > [...]
> >>>         say()
> >>>         {
> >>>                 if [ -z "$quiet" ]; then
> >>>                         echo "$@" >&2
> >>>                fi
> >>>         }
> >
> > I agree with the other reviewers that this should be fixed to use
> > printf, too, but that's another topic.
> Seconded.

-- 
Paolo G. Giarrusso - Ph.D. Student, Philipps-University Marburg
http://www.informatik.uni-marburg.de/~pgiarrusso/