Re: [PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH

From: Øyvind A. Holm <sunny@sunbase.org>
Date: Oct 9, 2012, 17:23 UTC
Message-ID: <CAA787rnXw2fR5DG5bhz9uF4ub8=jZgUvpJLVGJ5sGXGSF8VMEQ@mail.gmail.com>
In-Reply-To: <7v4nm3h8yr.fsf@alter.siamese.dyndns.org>

On 9 October 2012 19:05, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Øyvind A. Holm <sunny@sunbase.org> writes:
> > 40bfbde ("build: don't duplicate substitution of make variables",
> > 2012-09-11) breaks make by removing a necessary comma at the end of
> > "CC_LD_DYNPATH=-rpath" in line 414 and 423.
>
> The earlier one is a cut-and-paste-error regression.
>
> Isn't the one at line 423 from before 40bfbde, though?  If that is the
> case, I'm a bit hesitant to take that part of this patch without a
> second opinion.

It looks like it is, yes. More accurately, from 798a945 way back in
2008. If it hasn't caused any trouble since then, it probably won't. :)
The line was changed in 40bfbde, though, but AC_SUBST doesn't contain a
comma, so to be on the safe side, the first patch should be used.

But I made a minor copy+paste error in the commit message of that patch:

  "CC_LD_DYNPATH=-rpath" in line 414.

should be

  "CC_LD_DYNPATH=-Wl,-rpath" in line 414.

Just a minor, but slightly annoying detail.

Regards, Øyvind