Re: t5150-request-pull.sh fails on newest master in Debian

From: Øyvind A. Holm <sunny@sunbase.org>
Date: Jul 5, 2014, 14:24 UTC
Message-ID: <CAA787rnMonCuON+C0U5FDXKzjTBdpOusCpGLeWytDWaA1torEw@mail.gmail.com>
In-Reply-To: <1404525502.3109.25.camel@stross>

On 5 July 2014 03:58, David Turner <dturner@twopensource.com> wrote:

Show 7 quoted lines

> On Sat, 2014-07-05 at 02:09 +0200, Øyvind A. Holm wrote:
> <snip>
> > The test works. Seems as there's something fishy about the use of
> > --prefix in this specific commit (v2.0.1-472-g6f92e5f).
>
> Ok, now I can reproduce on my linode box (haven't tried it locally
> yet). I'll try to get a fix up once I figure out what's up.

Awesome. I've done some more "./configure --prefix" testing, and this is the result:

  # --prefix is set to non-existing directory
  ./configure --prefix=/usr/local/varprg/git.master.v2.0.1-472-g6f92e5f
    # ./t5150-request-pull.sh fails.

  # --prefix is set to non-existing directory, use trailing slash
  ./configure --prefix=/usr/local/varprg/git.master.v2.0.1-472-g6f92e5f/
    # ./t5150-request-pull.sh fails.

  # --prefix is set to existing directory
  ./configure --prefix=/usr/local/varprg/git.master.v2.0.1-442-g7fe6834
    # ./t5150-request-pull.sh fails.

  # --prefix is set to existing directory
  ./configure --prefix=/usr/local
    # ./t5150-request-pull.sh succeeds.

  # --prefix is set to existing directory
  ./configure --prefix=/usr/local/varprg
    # ./t5150-request-pull.sh succeeds.

  # --prefix is set to non-existing directory
  ./configure --prefix=/usr/local/varprg/a-long-directory-name-which-does-not-exist
    # ./t5150-request-pull.sh succeeds.

  ./configure --prefix=/usr/local/varprg/git.master.a-long-directory-name-which-does-not-exist
    # ./t5150-request-pull.sh succeeds.

So it's something with names like "git.master.v2.0.1-472-g6f92e5f" that "./configure --prefix" is picky about.

When testing this last night, I pushed the following branches to <https://github.com/sunny256/git> where I added all compiled files in various stages with "git add -f .":

  t5150-fail.configure-without-prefix
    Succeeds.
    "./configure"

  t5150-fail.configure-with-prefix
    Fails.
    "./configure --prefix=/usr/local/varprg/git.master.v2.0.1-472-g6f92e5f"

  t5150-fail.configure-prefix-usr-local
    Succeeds.
    "./configure --prefix=/usr/local"

Maybe something will turn up by diffing those branches. I've got to leave for now, but will have a look at this later tonight.

Cheers, Øyvind