Re: [PATCH/RFC] Documentation and Code: Fix misspellings and grammar

From: Leila <muhtasib@gmail.com>
Date: Jun 22, 2012, 23:24 UTC
Message-ID: <CAA3EhHJx7N=T77CRb=SfqOmaEFf8bHN5NZdx1u=q6+0d-fQcpA@mail.gmail.com>
In-Reply-To: <7vd34rlzxk.fsf@alter.siamese.dyndns.org>

On Fri, Jun 22, 2012 at 6:55 PM, Junio C Hamano <gitster@pobox.com> wrote:

> I am tempted to suggest "one word per patch" ;-)

I can do that, no problem. That's my preference too.

>
> Also you might want to take a look at
>
>    http://thread.gmane.org/gmane.comp.version-control.git/199033

Context is important, I agree.

Show 9 quoted lines

>
>> Do you think it's a problem to fix misspellings in printf output?
>
> It depends, but in a sense, typos in comments are a lot lower
> priority (nobody is hurt if we do not fix them, and if such a fix
> interferes with topics in flight, it is more nuisance than it is
> worth and it would be greatly appreciated if you hold off typofixes
> until the dust settles).
>

That makes total sense. I'll hold off on typos in comments. Actually, the only reason I included them was because they showed up when I did a 'git grep <misspelled word>', so I went ahead and fixed everything. How do I know when the dust has settled? Is that after you release a version? 1.7.11 released on June 17, so that wasn't that long ago?

Show 6 quoted lines

> Program output affects the end user experience, so it is more
> important.
>
> Changes to strings marked with _() for l10n should come early in the
> development cycle so that translators have enough time to prepare
> for it before the release.

Are we early in the dev cycle? Should I prepare a separate patch with just the misspellings that affect end user experience?

Thanks! Leila