git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sideband: skip unrecognized allowControlCharacters keywords

From
Thomas Bachem <mail@thomasbachem.com>
Date
Oct 16, 2026, 16:28 UTC
Message-ID
<CAA0xjtoyCjzjzNnoGdoA_o-TK9=nKK98mXEpE0y_jWJfah_Xow@mail.gmail.com>
In-Reply-To
<20261016142515.T1gr4%taahol@utu.fi>
Tuomas Ahola <taahol@utu.fi> wrote:
>> + value = end + !!*end;
>
> Reading CodingGuidelines, it seems that `!!` is a construct we would
> like to avoid:

I wrote it this way to match skip_prefix_in_csv() a few lines above, which steps past the comma the same way:

*out = value + !!*value;

so the two places in this parser read alike. Happy to spell it out as a conditional in a v2 if that's preferred, though.

Thomas
Previous: Tuomas AholaNext: Junio C Hamano
Message 3 of 6 in “sideband: skip unrecognized allowControlCharacters keywords”
  1. sideband: skip unrecognized allowControlCharacters keywordsThomas Bachem via GitGitGadget, Oct 16, 2026
  2. Tuomas AholaOct 16, 2026
  3. Thomas BachemOct 16, 2026
  4. Junio C HamanoOct 16, 2026
  5. Tuomas AholaOct 16, 2026
  6. Junio C HamanoNov 7, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.