Re: [PATCH] sideband: skip unrecognized allowControlCharacters keywords
- From
Thomas Bachem <mail@thomasbachem.com>
- Date
- Oct 16, 2026, 16:28 UTC
- Message-ID
- <CAA0xjtoyCjzjzNnoGdoA_o-TK9=nKK98mXEpE0y_jWJfah_Xow@mail.gmail.com>
- In-Reply-To
- <20261016142515.T1gr4%taahol@utu.fi>
Tuomas Ahola <taahol@utu.fi> wrote:
>> + value = end + !!*end; > > Reading CodingGuidelines, it seems that `!!` is a construct we would > like to avoid:
I wrote it this way to match skip_prefix_in_csv() a few lines above, which steps past the comma the same way:
*out = value + !!*value;
so the two places in this parser read alike. Happy to spell it out as a conditional in a v2 if that's preferred, though.
Thomas