Re: [PATCH] docs: .gitignore parsing is to the top of the repo

From: Andrew Berry <andrew@furrypaws.ca>
Date: Jul 7, 2021, 00:32 UTC
Message-ID: <CA0F1460-CB39-45DC-8DED-13F7ABA674D1@furrypaws.ca>
In-Reply-To: <xmqqr1gbf02i.fsf@gitster.g>

On 6 Jul 2021, at 20:18, Junio C Hamano wrote:

> Junio C Hamano <gitster@pobox.com> writes:
>>
>> Line rewrapping makes it hard to see what actually got changed,

To check, that's asked for, correct? Or is it better to do one commit with the word changes, another to clean up the wrapping?

Show 8 quoted lines

>> but
>> does this only move "(up to the top-level of the work tree)" around
>> without anything else, as discussed?
>>
>> If you do "toplevel" -> "top-level" while at it, perhaps we would
>> want to correct "work tree" -> "working tree".
>>
>> Looking better.

Yes, I realized I sent the wrong file when reviewing the sent email, hence the followup. Aside, it's not clear to me how to send patch emails that _also_ have not-to-be-committed notes like "oops, ignore the last". First time contributor problems!

Show 6 quoted lines

> Another tangent.  The discovery process used for the .gitattributes
> files is identical to what is done to the .gitignore files; we may
> want to make sure that the explanation we give in our documentation
> won't cause the same confusion you are trying to avoid with this
> change.  Such a fix does not have to be (and probably should not be)
> a part of this change, though.

I'm out of the office for the next week, but otherwise I'm glad to take that on when I'm back if no one else picks it up.