Re: t/t1304: avoid -d option to setfacl (db82657)

From: Brandon Casey <drafnel@gmail.com>
Date: Nov 18, 2011, 05:37 UTC
Message-ID: <CA+sFfMc6BCPvk1FCjZwyY_pWqXBut3D--OfrFEcfK5p97D-KHQ@mail.gmail.com>
In-Reply-To: <gitster/git/commit/db826571e4099066fe44233d95642591016c831b/729354@github.com>

[cc git@vger.kernel.org since that is the appropriate place for this discusion]

On Thu, Nov 17, 2011 at 8:59 PM, wsp <reply+c-729354-3460aca0fa61e627f9d1a271cf70a99d5c1e7e4e-921167@reply.github.com> wrote:

> Could this test case be reviewed again? It fails on FreeBSD where the appropriate way to specify default ACL's is with the "-d" option. The "d[efault]:" syntax is invalid on FreeBSD.

Well, I'm not sure there is a right answer here.

   Linux accepts -d or "d[efault]"
   Solaris only accepts "d[efault]"
   FreeBSD only accepts -d
   a quick search shows z/OS only accepts "d[efault]"
   other?

I think most everything else rolls their own implementation into chmod or chacl or something like that.

The abandoned POSIX draft does actually specify the FreeBSD behavior.

So I think it's kind of a toss-up. Which option we choose should probably depend on whether we get more test coverage by using the "d[efault]" notation or by using the -d option. That depends on whether there are more Solaris users compiling git or whether there are more FreeBSD users. I don't know the answer to that either. I tend to think there are very few of either.

-Brandon