Re: [PATCH 4/4] cmd_psuh: Prefer repo_config for config lookup

From: JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com>
Date: May 16, 2025, 19:06 UTC
Message-ID: <CA+rGoLfk=m4QzrRnCsweBsL35yiLEUHJagetEL9DD2Pty5FgAQ@mail.gmail.com>
In-Reply-To: <aCeDZgaNWPbDV0Ra@google.com>

So, I've consolidated these patches in only 3 rather than 4, the UNUSED fix patch was actually delving into 2 patches so I fixed that in a single one.

Also the commit messages, I gotta admit I was given the same feedback from Junio But these were actually written before that, Apologies I should've checked once.

Show 6 quoted lines

> I'd prefer to see this stick to the prior formula of including only
> small chunks of the function, rather than a full function you can copy
> and paste. Because this is a tutorial, and the goal is for learners to
> understand each section of code as they add it, not just for them to
> paste it into their editor and hit run.
>

Yes I've done this. I've just changed git_config to repo_config without changing the other parts.

Show 15 quoted lines

> So, I don't think it's necessary for you to add the rest of the function
> here in the process of switching to repo_config from git_config.
>
>
> Generally, I find the changes to update the code snippets
> unobjectionable and don't have a problem with the added prose
> beyond a couple nits. But as I assume you sent this series as a way to
> learn more about the codebase, definitely please revisit your commit
> messages to align their style with the rest of the codebase.
>
> But I think with the stuff I called out taken into account in v2, this
> series is good. Thanks for the effort to update it. I'd also like to
> update github.com/nasamuffin/git/tree/psuh once this series lands, if
> you can point me to a branch of yours with the sample code I can pull
> from :)

Surely, I will write the builtin function with a test case and make sure it compiles.

> (Or, as we discussed when I sent this doc in the first place, does it
> make sense for a branch with the sample code to be maintained
> only-best-effort on git/git itself?)
>

I think it's fine both ways as long as we link it to the proper place in the docs.

>  - Emily
>
> >
> >  ----

...

In the new series I tried to keep commit messages as good as I could without naming every line I edited and just keeping it to why instead of what.

Thank you,

-Jayatheerth