git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSOC][PATCH v2] Remove outdated mentoring mailing list reference

From
JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com>
Date
Mar 21, 2025, 14:32 UTC
Message-ID
<CA+rGoLeYJEbpC6=mUPuOr=i6pE9w20OeJSOzG0SQPVpBWDbTgQ@mail.gmail.com>
In-Reply-To
<xmqqa59evffd.fsf@gitster.g>
On Fri, Mar 21, 2025 at 4:06 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
>
> K Jayatheerth <jayatheerthkulkarni2005@gmail.com> writes:
>
> > Subject: Re: [GSOC][PATCH v2] Remove outdated mentoring mailing list reference
>
> [Documentation/SubmittingPatches]
>
>     The first line of the commit message should be a short description (50
>     characters is the soft limit, see DISCUSSION in linkgit:git-commit[1]),
>     and should skip the full stop.  It is also conventional in most cases to
>     prefix the first line with "area: " where the area is a filename or
>     identifier for the general area of the code being modified, e.g.
>
Went through the discussion
Show 15 quoted lines
>     * doc: clarify distinction between sign-off and pgp-signing
>     * githooks.txt: improve the intro section
>
>     If in doubt which identifier to use, run `git log --no-merges` on the
>     files you are modifying to see the current conventions.
>
> > and clarify tutorial prerequisites
>
> Do not do this.  What you have on the e-mail "Subject:" line is the
> first paragraph (whose definition is block of text delineated by
> blank lines) of the commit log message, and the first paratraph in
> the body of a patch e-mail is the second paragraph.  You do not
> start your second paragraph at half-sentence, as if it were a
> continuation of an incomplete previous sentence.
>

Thank you for the feedback, I will make sure not to repeat them in the further patches

-Jay
Previous: JAYATHEERTH K
Message 21 of 21 in “Remove outdated mentoring mailing list reference and clarify tutorial prerequisites”
  1. K JayatheerthMar 15, 2025
  2. [GSOC][PATCH 2/3] Update function signature and UNUSED to include struct repository and modify builtin.h accordinglyK Jayatheerth, Mar 15, 2025
  3. [GSOC][PATCH 3/3] Replace git_config(...) with repo_config(...) for modern Git compatibilityK Jayatheerth, Mar 15, 2025
  4. JAYATHEERTH KMar 15, 2025
  5. Junio C HamanoMar 17, 2025
  6. [GSOC][PATCH v2] Remove outdated mentoring mailing list referenceK Jayatheerth, Mar 19, 2025
  7. Junio C HamanoMar 21, 2025
  8. [[GSOC][PATCH v3] 1/3] docs: drop inactive mentoring list, add C prereqK Jayatheerth, Mar 21, 2025
  9. [[GSOC][PATCH v3] 2/3] docs: update function signature, add UNUSED macroK Jayatheerth, Mar 21, 2025
  10. Junio C HamanoMar 23, 2025
  11. [[GSOC][PATCH v3] 3/3] docs: replace git_config with repo_configK Jayatheerth, Mar 21, 2025
  12. Junio C HamanoMar 23, 2025
  13. JAYATHEERTH KMar 24, 2025
  14. Junio C HamanoMar 24, 2025
  15. [[GSOC][PATCH v4] 2/3] docs: update function signature, add UNUSED macroK Jayatheerth, Mar 24, 2025
  16. [[GSOC][PATCH v4] 3/3] docs: replace git_config with repo_configK Jayatheerth, Mar 24, 2025
  17. JAYATHEERTH KMar 24, 2025
  18. Junio C HamanoMar 26, 2025
  19. JAYATHEERTH KMar 26, 2025
  20. JAYATHEERTH KMar 29, 2025
  21. JAYATHEERTH KMar 21, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.