Re: [PATCH 2/2] t/pack-refs-tests: drop '-f' from test_path_is_missing
- From
K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
- Date
- Mar 22, 2026, 13:29 UTC
- Message-ID
- <CA+rGoLd71J31P98_4jC94Zo+oN6qk2ZX65wnOHU=xPwthhWpqQ@mail.gmail.com>
- In-Reply-To
- <6f71fb3e9a39d8cec62bbbc83e53543be40feef1.1774183586.git.gitgitgadget@gmail.com>
Hi Jayesh, Thanks for the patch
It is a textbook micro project ;) But I could find a few flaws in it.
Show 15 quoted lines
> test_path_is_missing expects exactly one argument: the path to
> --- a/t/pack-refs-tests.sh
> +++ b/t/pack-refs-tests.sh
> @@ -1,9 +1,3 @@
> -#!/bin/sh
> -
> -test_description='test pack-refs'
> -
> -. ./test-lib.sh
> -
> pack_refs=${pack_refs:-pack-refs}
>
> test_expect_success 'enable reflogs' '
> --
> gitgitgadgetPatch 2 removes exactly what Patch 1 adds. You'll have to use rebase -i i.e interactive rebase and change em.
Here are some docs [1]
Regards, - Jayatheerth
1 - https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History