Re: [PATCH] simple-ipc: work around issues with Cygwin's Unix socket emulation
- From
Adam Dinwoodie <adam@dinwoodie.org>
- Date
- Nov 12, 2021, 08:50 UTC
- Message-ID
- <CA+kUOanaVM183qtubr+=eLebm2G3+tQwMF2PAHT_xfeeNNHr+w@mail.gmail.com>
- In-Reply-To
- <xmqqtugkx7e2.fsf@gitster.g>
On Wed, 10 Nov 2021 at 17:11, Junio C Hamano <gitster@pobox.com> wrote:
Show 26 quoted lines
> > "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> > writes: > > > From: Johannes Schindelin <johannes.schindelin@gmx.de> > > > > Cygwin emulates Unix sockets by writing files with custom contents and > > then marking them as system files. > > > > The tricky problem is that while the file is written and its `system` > > bit is set, it is still identified as a file. This caused test failures > > when Git is too fast looking for the Unix sockets and then complains > > that there is a plain file in the way. > > > > Let's work around this by adding a delayed retry loop, specifically for > > Cygwin. > > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > --- > > OK, I was about to ask for an Ack from Cygwin folks but I see the > original that got Ack is more-or-less the same except for placement > of the comments (and this version of course is more polished than > the "this should work---please try it" version), so let me pretend > that this got tested-by from those who were happy with the original > in the old thread.
Late to the party – other bits of life got in the way – but I've just confirmed this appears to resolve the issue for me too.
Adam