Re: [PATCH] t/t1517: indicate that `gui--askyesno` fails with GIT_TEST_INSTALLED

From: Adam Dinwoodie <adam@dinwoodie.org>
Date: Dec 31, 2025, 19:09 UTC
Message-ID: <CA+kUOanGT2eOHexpXk3jEKY6CZjutN_099Sihy2V=R0M9593pg@mail.gmail.com>
In-Reply-To: <20251201031040.1120091-1-brianmlyles@gmail.com>

On Mon, 1 Dec 2025 at 03:10, Brian Lyles <brianmlyles@gmail.com> wrote:

Show 22 quoted lines

>
> Commit e749c87e75 (git-gui: provide question helper for retry fallback
> on Windows, 2025-08-28) causes `git-gui--askyesno` to be installed when
> running `make install`. This triggers a new occurrence of the issue
> noted in commit c4cf8caadd (t/t1517: mark tests that fail with
> GIT_TEST_INSTALLED, 2025-08-19), which prevents Git v2.52.0 from
> building in nixpkgs [1]. Indicate that this is an expected failure.
>
> [1]: https://github.com/NixOS/nixpkgs/issues/465178#issuecomment-3580790826
>
> Signed-off-by: Brian Lyles <brianmlyles@gmail.com>
> ---
>
> Note that while this does allow nixpkgs to build v2.52.0, I suspect that
> this sort of issue is likely to crop up again in the future. I wonder if
> it may be beneficial to make some more fundamental change to this test
> to avoid future occurrences. If that is preferred (and something that
> someone has time to tackle in the near future), I am happy to allow this
> patch to be obviated by such a change.
>
>  t/t1517-outside-repo.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Notwithstanding the discussion at https://lore.kernel.org/git/xmqqect7fhnp.fsf@gitster.g/ et seq, it'd be good to get this fix in a release. Ideally we'd have a better long-term fix, but I don't think that should prevent fixing the problems we have right now.

Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>