Re: [PATCHv2 2/2] git-remote-mediawiki: refactoring get_mw_pages function

From: Simon Perrat <simon.perrat@gmail.com>
Date: Jun 12, 2012, 09:06 UTC
Message-ID: <CA+hdvHhn1G=T=KjNvgXa-2M6oh2znbHmfZFZYPdqKhtybh_MoQ@mail.gmail.com>
In-Reply-To: <1339442945-8561-2-git-send-email-Pavel.Volek@ensimag.imag.fr>

2012/6/11 Pavel Volek <Pavel.Volek@ensimag.imag.fr>:

Show 8 quoted lines

> +sub get_mw_all_pages {
> +       my $pages = shift;
> +       # No user-provided list, get the list of pages from the API.
> +       my $mw_pages = $mediawiki->list({
> +               action => 'query',
> +               list => 'allpages',
> +               aplimit => 500
> +       });

Indentation should be 8 columns wide.

> +       if ($import_media) {
> +               # Attach list of all pages for meadia files from the API,

me*dia

> +
> +       # Get pages of related media files.

This comment seems to be paraphrasing the line below, could be removed maybe.

> +       if ($import_media) {
> +               get_mw_pages_for_linked_mediafiles(\@tracked_pages, \%{$pages});
> +       }
> +}

Not much to say on this patch, as this is basically splitting existing code.