Re: [PATCH/RFC 0/2] fast-import: commit from null_sha1

From: Dmitry Ivankov <divanorama@gmail.com>
Date: Sep 18, 2011, 21:40 UTC
Message-ID: <CA+gfSn_WG_S+QJK5O_4D62KV78-77QO_gyy7PeFGRJYW4cQu8A@mail.gmail.com>
In-Reply-To: <20110918213050.GJ2308@elie>

On Mon, Sep 19, 2011 at 3:30 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 10 quoted lines

> Dmitry Ivankov wrote:
>
>> These patches make fast-import treat
>>     commit refs/heads/master
>>     ...
>>     from `null_sha1`
>> like any other missing parent sha1 - reject such input.
>
> Are you sure the existing support for "from 0{40}" is not deliberate
> and that no one is relying on it?

It is hard to guess. There is no test for it in t/t9300-fast-import.sh, no mention in the Documentation, but sometimes a user can see null_sha1 from git. I hope that it pops up only when something is read to simplify the format and never accepted in 'write' commands or as an argument.

>  If and only if you are, then this
> seems like a good idea (a single patch that both makes the behavior
> change and adds a test for it should be easier to review).
>