git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC] fast-import: note deletion command

From
Dmitry Ivankov <divanorama@gmail.com>
Date
Sep 18, 2011, 20:07 UTC
Message-ID
<CA+gfSn9sdTzQghqQp6hcO-9kN9mPx2JLRig79Rgx2FqGWXXp=A@mail.gmail.com>
Hi,

fast-import is able to write notes provided a command N <note_content_data_specification> <commit_specification>

There is no documented command to delete a note. It can't be easily replaced with Delete command on notes tree because of notes fanout.

But fast-import interprets 0{40} data_specification as a note deletion command. It is consistent with fast-import internals where null_sha1 is used for absent/unknown object. But is not consistent with file Modify command nor looks like a common convention in git ui.

So the questions are:
- should 0{40} not be treated as deletion toggle? Downside is that
it is used as one in t/t9301-fast-import-notes.sh.
- how should a documented way to delete notes look like?
ND commit_sha1 # One may think there are also NC, NR, NM
N delete commit_sha1
# Only :mark, full-40-byte-sha1 and 'inline' are allowed currently.
# So no clashes arise, but then one may also want M 'delete' path
# command to work too.
Next: Jonathan Nieder
Message 1 of 10 in “[RFC] fast-import: note deletion command”
  1. Dmitry IvankovSep 18, 2011
  2. Jonathan NiederSep 18, 2011
  3. Sverre RabbelierSep 18, 2011
  4. Dmitry IvankovSep 18, 2011
  5. fast-import wishlist (Re: [RFC] fast-import: note deletion command)Jonathan Nieder, Sep 18, 2011
  6. Branch deletion (Re: [RFC] fast-import: note deletion command)Jonathan Nieder, Sep 18, 2011
  7. Sverre RabbelierSep 18, 2011
  8. Jonathan NiederSep 18, 2011
  9. Dmitry IvankovSep 18, 2011
  10. Sverre RabbelierSep 18, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.