Re: Regression (?) in core.safecrlf=false messaging

From: Anthony Sottile <asottile@umich.edu>
Date: Jun 4, 2018, 15:43 UTC
Message-ID: <CA+dzEBn7cCey-LDa1Y-PUeFQs7JiucS30FFiLfw4sfu6ZX34JQ@mail.gmail.com>
In-Reply-To: <20180604075549.GA21063@tor.lan>

On Mon, Jun 4, 2018 at 12:55 AM, Torsten Bögershausen <tboegi@web.de> wrote:

Show 16 quoted lines

>
> Does the following patch fix your problem ?
>
> diff --git a/config.c b/config.c
> index 6f8f1d8c11..c625aec96a 100644
> --- a/config.c
> +++ b/config.c
> @@ -1233,7 +1233,7 @@ static int git_default_core_config(const char *var, const char *value)
>                 }
>                 eol_rndtrp_die = git_config_bool(var, value);
>                 global_conv_flags_eol = eol_rndtrp_die ?
> -                       CONV_EOL_RNDTRP_DIE : CONV_EOL_RNDTRP_WARN;
> +                       CONV_EOL_RNDTRP_DIE : 0;
>                 return 0;
>         }
>

Yes!  After applying that patch:

```

$ PATH=$PWD/prefix/bin:$PATH bash test.sh
+ git --version
git version 2.18.0.rc1.dirty
+ rm -rf repo
+ git init repo
Initialized empty Git repository in /tmp/git/repo/.git/
+ cd repo
+ git config core.autocrlf input
+ git config core.safecrlf false
+ echo -en 'foo\r\nbar\r\n'
+ git add f

```

Anthony