[PATCH] push: don't show Done with --quiet --porcelain

From: Josh Rabinowitz <joshr@joshr.com>
Date: Aug 31, 2015, 16:40 UTC
Message-ID: <CA+WR+g7frN4uV12dxahxZbr-5az7sj3zx2oN-Z3rKH0_Y8jqqg@mail.gmail.com>

Change so 'git push --porcelain --quiet' emits no text when there is no error. This makes the --quiet option here more consistent with other git commands.

Signed-off-by: josh rabinowitz <joshr@joshr.com>
---
 transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/transport.c b/transport.c
index 40692f8..0021b3f 100644
--- a/transport.c
+++ b/transport.c
@@ -1209,7 +1209,7 @@ int transport_push(struct transport *transport,
                transport_update_tracking_ref(transport->remote, ref, verbose);
        }

-       if (porcelain && !push_ret)
+       if (!quiet && porcelain && !push_ret)
            puts("Done");
        else if (!quiet && !ret && !transport_refs_pushed(remote_refs))
            fprintf(stderr, "Everything up-to-date\n");
--
2.3.2 (Apple Git-55)