git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/9] completion: improve handling of DWIM mode for switch/checkout

From
Jacob Keller <jacob.keller@gmail.com>
Date
May 28, 2020, 08:53 UTC
Message-ID
<CA+P7+xrxt5oybijmRWFd-fMYxKSB8cnuX188g9x9UkRcmwigVw@mail.gmail.com>
In-Reply-To
<CA+P7+xoTJzsV=NbWeWs+fbdgETXwqUs0T9MToBbrGJ0EA-bFcA@mail.gmail.com>
On Wed, May 27, 2020 at 12:41 PM Jacob Keller <jacob.keller@gmail.com> wrote:
Show 9 quoted lines
> >
> > and without getting any answer to them.  Perhaps the proposed log
> > message for [1/9] can be made a bit more robust to cover it?
> >
>
> Sure, I'll look at what I can do to make this more logical.
>
> > Thanks.
> >

I'll have a v3 which splits most of the tests into their own patch with a better description of the reasoning of the problem with output and the new expected behavior. The commit descriptions for the improvements will then focus primarily on the reasons for the particular method of implementing that output. It's a few more patches, but hopefully it will read more logically, and we can help settle some of the open questions:

particular to interest me is: what sort of words should we complete when completing a new branch name for --orphan, -c/-C and -b/-B? I think all of these ought to remain as consistent as possible, but I'm not sure what other folks think.

Thanks, Jake

Previous: Jacob KellerNext: Jacob Keller
Message 10 of 13 in “refactor completion for switch and checkout”
  1. 0/9 refactor completion for switch and checkoutJacob Keller, May 27, 2020
  2. 4/9 completion: perform DWIM logic directly in __git_complete_refsJacob Keller, May 27, 2020
  3. 9/9 completion: improve handling of --orphan option of switch/checkoutJacob Keller, May 27, 2020
  4. 8/9 completion: improve handling of -c/-C and -b/-B in switch/checkoutJacob Keller, May 27, 2020
  5. 3/9 completion: extract function __git_dwim_remote_headsJacob Keller, May 27, 2020
  6. 6/9 completion: improve handling of --detach in checkoutJacob Keller, May 27, 2020
  7. 2/9 completion: improve handling of DWIM mode for switch/checkoutJacob Keller, May 27, 2020
  8. Junio C HamanoMay 27, 2020
  9. Jacob KellerMay 27, 2020
  10. Jacob KellerMay 28, 2020
  11. 1/9 completion: replace overloaded track term for __git_complete_refsJacob Keller, May 27, 2020
  12. 5/9 completion: improve completion for git switch with no optionsJacob Keller, May 27, 2020
  13. 7/9 completion: improve handling of --track in switch/checkoutJacob Keller, May 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.