Re: Should `git remote show` display excluded branches as to-be-fetched?
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Jun 12, 2022, 06:36 UTC
- Message-ID
- <CA+P7+xqfthRZkn76FxG8xuGU670k0zyCCTe0d26_pe1HVTkXpQ@mail.gmail.com>
- In-Reply-To
- <xmqq1qvwfntm.fsf@gitster.g>
On Fri, Jun 10, 2022 at 10:08 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 41 quoted lines
> > Pavel Rappo <pavel.rappo@gmail.com> writes: > > > Here's a console session: > > > > % git config --get-all remote.jdk19.fetch > > +refs/heads/*:refs/remotes/jdk19/* > > ^refs/heads/pr/* > > Thanks > > "Negative refspecs" is relatively new feature introduced in c0192df6 > (refspec: add support for negative refspecs, 2020-09-30), so it > would not be so surprising if it still had some surprising behaviour > ;-) > > Jacob, care to take a look? > > > % git remote show jdk19 > > > > * remote jdk19 > > Fetch URL: git@github.com:openjdk/jdk19.git > > Push URL: git@github.com:openjdk/jdk19.git > > HEAD branch: master > > Remote branches: > > master tracked > > pr/1 new (next fetch will store in remotes/jdk19) > > pr/2 new (next fetch will store in remotes/jdk19) > > pr/3 new (next fetch will store in remotes/jdk19) > > Local ref configured for 'git push': > > master pushes to master (fast-forwardable) > > > > I would naively expect the pr/1, pr/2, and pr/3 branches to be either: > > > > - not displayed, or better > > - displayed with a hint that they won't be fetched (since they match a > > _negative_ refspec, which is the second line in the `git config` > > output above) > > > > Thanks, > > -Pavel
This is almost certainly an oversight in that the particular code path does not process negative refspecs. I can hopefully take a closer look at this next week.