Re: [RESEND PATCH] diff: recurse into nested submodules for inline diff

From: Jacob Keller <jacob.keller@gmail.com>
Date: May 6, 2017, 01:24 UTC
Message-ID: <CA+P7+xqMNiHGi=NVjTHCmnkk3u2BVC5Kfs6p6S3m+LwZr6vkaQ@mail.gmail.com>
In-Reply-To: <20170504214355.14179-1-sbeller@google.com>

On Thu, May 4, 2017 at 2:43 PM, Stefan Beller <sbeller@google.com> wrote:

Show 19 quoted lines

> When fd47ae6a5b (diff: teach diff to display submodule difference with an
> inline diff, 2016-08-31) was introduced, we did not think of recursing
> into nested submodules.
>
> When showing the inline diff for submodules, automatically recurse
> into nested submodules as well with inline submodule diffs.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>
> This is a resend of
> https://public-inbox.org/git/20170331231733.11123-3-sbeller@google.com/
>
> In the cover letter of that patch, I said I would want to redo the tests with
> scrubbed output. However given the widespread use of unscrubbed output,
> I think this is fine as-is to include.
>
> Thanks,
> Stefan

Fix looks obviously correct to me. I would like to change the tests to not use the unscrubbed output, but that's a problem for a separate patch.

Thanks, Jake