Re: [PATCH v7 4/4] notes: teach git-notes about notes.<ref>.mergestrategy option
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Aug 14, 2015, 22:48 UTC
- Message-ID
- <CA+P7+xqHzE5b7_yEqnCDq_vVJGSnsHPV8qJrXqUAGW=h_5C0mQ@mail.gmail.com>
- In-Reply-To
- <xmqq8u9dh6lq.fsf@gitster.dls.corp.google.com>
On Fri, Aug 14, 2015 at 3:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 25 quoted lines
> Jacob Keller <jacob.e.keller@intel.com> writes:
>
>> diff --git a/builtin/notes.c b/builtin/notes.c
>> index 12a42b583f98..bdfd9c7d29b4 100644
>> --- a/builtin/notes.c
>> +++ b/builtin/notes.c
>> ...
>> @@ -833,7 +833,14 @@ static int merge(int argc, const char **argv, const char *prefix)
>> usage_with_options(git_notes_merge_usage, options);
>> }
>> } else {
>> - git_config_get_notes_strategy("notes.mergestrategy", &o.strategy);
>> + if (!skip_prefix(o.local_ref, "refs/notes/", &short_ref))
>> + die("Refusing to merge notes into %s (outside of refs/notes/)",
>> + o.local_ref);
>> +
>
> Sorry, but I lost track.
>
> Do I understand correctly the consensus on the previous discussion?
> My understanding is:
>
> (1) We do not currently refuse to merge notes into anywhere outside
> of refs/notes/;
>We do. I mis understood the original code. We check inside "init_notes_check()", which will check if the ref is under refs/notes/
Show 8 quoted lines
> (2) But that is not a designed behaviour---we simply forgot to > check it---we should start checking and refusing. > > If that is the concensus, having this check somewhere in the merge() > function is indeed necessary, but this looks very out of place. > Think what happens if the user passes "--stratagy manual" from the > command line. This check is not even performed, is it? >
It is checked (also) in init_notes_check(). I just happen to re-check here because I didn't want to out-right ignore it in some weird flow where it was incorrect.
Show 5 quoted lines
> I'd prefer to see: > > * "Let's start making sure that we do not allow touching outside > refs/notes/" as a separate patch, perhaps as a preparatory step. >
We already don't allow it. See init_notes_check()
> * Have the check apply consistently, regardless of where the > strategy comes from.
It already does. There is just a second check. I could completely remove that check if you like, but then we'd check config since we don't run init_notes_check until after we find the merge strategy.
Show 22 quoted lines
>
> * That separate patch to add this restriction should test that
> the refusal triggers correctly when it should, and it does not
> trigger when it shouldn't.
>
>> + strbuf_addf(&merge_key, "notes.%s.mergestrategy", short_ref);
>> +
>> + if (git_config_get_notes_strategy(merge_key.buf, &o.strategy))
>> + git_config_get_notes_strategy("notes.mergestrategy", &o.strategy);
>> }
>
> I think you are leaking merge_key after you are done using it.
>
> It is tempting to suggest writing the above like so:
>
> git_config_get_notes_strategy(merge_key.buf, &o.strategy)) ||
> git_config_get_notes_strategy("notes.mergestrategy", &o.strategy);
>
> which might make it more obvious what is going on, but I do not care
> too deeply about it. To be honest, I am not sure which one is
> easier to read in the longer term myself ;-).
>the || strategy results in a warning that we are checking and then dropping the outcome.
> Thanks.
Regards, Jake