git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v11 0/8] submodule inline diff format

From
Jacob Keller <jacob.keller@gmail.com>
Date
Aug 31, 2016, 22:43 UTC
Message-ID
<CA+P7+xppw7NFX5d7EM+dXKq4v-hMzJgg0mhGmv8wmUJ52i8Nzw@mail.gmail.com>
In-Reply-To
<xmqq37lk3n17.fsf@gitster.mtv.corp.google.com>
On Wed, Aug 31, 2016 at 9:45 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> Jacob Keller <jacob.e.keller@intel.com> writes:
>
>>> We probably should release for the error case. I'll do that. I don't
>>> believe do_submodule_path ensures that the passed in argument is
>>> guaranteed to not be initialized or used.
>>>
>>> Thanks,
>>> Jake
>>
>> Here's the squash for this fix.
>
> It seems that the topic has been quiet since the message I am
> responding to.  Have all the issues been resolved, or are there
> still some loose ends to be hashed out?
>
> Hoping that the answer is "the former", I'll mark this topic as
> "Waiting for a reroll."
>
> Thanks.

As far as I know they have. You mentioned a few nits in one comment, but then said you had a re-worded message that you queued so I assumed those nits were all squashed in. If that's correct, and you already applied my squash for the strbuf leak I think we're good and I had nothing coming in a future re-roll based on looking at what you have queued in your jk/diff-submodule-inline-diff branch.

Regards, Jake

Previous: Junio C Hamano
Message 18 of 18 in “submodule inline diff format”
  1. 0/8 submodule inline diff formatJacob Keller, Aug 25, 2016
  2. 2/8 diff.c: remove output_prefix_length fieldJacob Keller, Aug 25, 2016
  3. 3/8 graph: add support for --line-prefix on all graph-aware outputJacob Keller, Aug 25, 2016
  4. 4/8 diff: prepare for additional submodule formatsJacob Keller, Aug 25, 2016
  5. 5/8 allow do_submodule_path to work even if submodule isn't checked outJacob Keller, Aug 25, 2016
  6. Junio C HamanoAug 26, 2016
  7. Keller, Jacob EAug 26, 2016
  8. 6/8 submodule: convert show_submodule_summary to use struct object_id *Jacob Keller, Aug 25, 2016
  9. 7/8 submodule: refactor show_submodule_summary with helper functionJacob Keller, Aug 25, 2016
  10. 8/8 diff: teach diff to display submodule difference with an inline diffJacob Keller, Aug 25, 2016
  11. 1/8 cache: add empty_tree_oid object and helper functionJacob Keller, Aug 25, 2016
  12. Stefan BellerAug 26, 2016
  13. Keller, Jacob EAug 26, 2016
  14. Jeff KingAug 26, 2016
  15. Jacob KellerAug 26, 2016
  16. Jacob KellerAug 26, 2016
  17. Junio C HamanoAug 31, 2016
  18. Jacob KellerAug 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.