Re: [PATCH v3 1/2] diff: add --line-prefix option for passing in a prefix
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Aug 10, 2016, 22:53 UTC
- Message-ID
- <CA+P7+xpmWu6eeoPkenn=-2s=pW8GdCtBpRGcqDWkmASPmMsetA@mail.gmail.com>
- In-Reply-To
- <xmqq4m6s476t.fsf@gitster.mtv.corp.google.com>
On Wed, Aug 10, 2016 at 2:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> You might be envisioning a future enhancement where the recursive > one uses not "-Submodule commit A"/"-Submodule commit B", and not > "diff A B", but "log -p A...B" in the submodule, and in such a case, > it might make sense to run "log -p --graph A...B" instead when the > command the end user run in the superproject asked for "--graph". > You would use the same "--line-prefix='| | | '" when running the > "log -p --graph A...B" command in the submodule, so that the output > for the submodule will go _after_ the graph of the superproject, but > in that case, the output for the submodule would also include its > own graph to show the relationship between A and B. The line-prefix > must come before that graph part (and also if it is "git log" run in > the submodule, the same line-prefix must come before each line of > the log message output). >
Oops, you are correct. In this case, the line-prefix should come first, and I will reverse this.
Thanks, Jake